Fix FRNationalIdentificationNumber validation for Corsica department #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -213,6 +213,8 @@ def test_FRNationalIdentificationNumber(self): | |||
| invalid = { | |||
| '369067543002289': error_format, # Gender mismatch | |||
| '869069873002289': error_format, # Bad Department | |||
| '878062073002289': error_format, # Bad Department with birthdate | |||
| '869062A73002289': error_format, # Bad Department with birthdate | |||
There was a problem hiding this comment.
I would be more specific in the comment message, and also add some entries in the valid dictionary.
There was a problem hiding this comment.
Alright, I'll do this
|
@claudep Good for me, I added few tests and updated comments |
claudep
added a commit
that referenced
this pull request
Nov 27, 2015
…tment Fix FRNationalIdentificationNumber validation for Corsica department
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error was made on the
FRNationalIdentificationNumbervalidation, department 20 (for Corsica) can't be ignored if birthdate is older than 1976.Before January 1976, department number for Corsica was 20. From 1976, Corsica has been divided into two number : 2A and 2B, as said on the French departments page of wikipedia :
Therefore we can't consider a French national identification number invalid if department number is 20 and birthdate < 1976.
For the record, this is not specified on the English version of the French departments page of wikipedia.