Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Django 1.5 / 1.6 and Python 2.6 #170

Conversation

benkonrath
Copy link
Member

Motivated by the unknown Django 1.5 test errors in #152, I propose we drop support for unsupported versions of Django (1.5 and 1.6) which means we can also drop Python 2.6 support. This would be for the next release of localflavor (1.2). I'm curious to hear what people think about this.

@claudep
Copy link
Member

claudep commented Sep 2, 2015

My opinion is that we should release ASAP as I know about several people waiting for a release with recent fixes.
Then I'm OK to drop 1.5/1.6 for next release+1.

@benkonrath
Copy link
Member Author

That's ok by me. Any idea when the next release is coming?

@claudep
Copy link
Member

claudep commented Sep 2, 2015

As soon as one of the releasers finds time to do it. Sorry, I cannot be more precise.

@benkonrath
Copy link
Member Author

No problem, this answers my question actually. I wasn't sure if you meant ASAP to mean in the next couple of days. Thanks.

@jieter
Copy link
Contributor

jieter commented Oct 6, 2015

Would be nice if we could move on with this...

@benkonrath benkonrath force-pushed the drop-support-for-django-15-16-python-26 branch 2 times, most recently from 7749768 to 5e723f4 Compare November 12, 2015 18:50
@benkonrath benkonrath added this to the 1.3 milestone Nov 22, 2015
@benkonrath benkonrath force-pushed the drop-support-for-django-15-16-python-26 branch from 5e723f4 to ae84b0a Compare November 27, 2015 19:25
@benkonrath
Copy link
Member Author

I've just updated / rebased this PR. I'm just looking for a quick sanity check. Thanks.

@@ -1,5 +1,4 @@
invoke==0.11.1
coverage==3.7.1
flake8==2.2.5
django-discover-runner==1.0
six==1.8.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe six>1.8.0 (or six==1.10.0)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it doesn't need to be in that PR, in fact.

@benkonrath
Copy link
Member Author

I included the updated six version in this PR. Thanks.

@claudep
Copy link
Member

claudep commented Nov 28, 2015

Looks good, please push it!

@benkonrath benkonrath deleted the drop-support-for-django-15-16-python-26 branch November 28, 2015 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants