Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBAN updates #139

Closed
wants to merge 2 commits into from
Closed

IBAN updates #139

wants to merge 2 commits into from

Conversation

benkonrath
Copy link
Member

  • Add new countries for IBAN:
    • Timor-Leste
    • Kosovo (active as of 1 February 2015). I think it's ok to add this now because the format is already determined.

Reference:
http://www.swift.com/dsp/resources/documents/IBAN_Registry.pdf

  • Add more tests to IBAN and BIC to give the generic module 100% test coverage.

@benkonrath
Add Timor-Leste and Kosovo to IBAN list.
7c7720e
@benkonrath
Add more IBAN tests.
a8665f6 
The generic module now has 100% test coverage.
@mxsasha
Copy link
Member

mxsasha commented Jan 12, 2015

Thanks, merged!

@benkonrath
Copy link
Member Author

I guess github didn't detect that you merged this PR so I'm manually closing the issue. Thanks for reviewing this.

@benkonrath benkonrath closed this Jan 12, 2015
@benkonrath benkonrath deleted the iban_updates branch September 2, 2015 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benkonrath @mxsasha