Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a model field for Ecuadorian provinces #138

Closed
wants to merge 2 commits into from

Conversation

jleeothon
Copy link
Contributor

No description provided.


def setUp(self):
self.form = ECPlaceForm({
'province':'SD'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a space after the colon here?

@jezdez jezdez added this to the 1.2 milestone Dec 30, 2014
@benkonrath
Copy link
Member

@jleeothon Thanks for your contribution and sorry for the delay in finishing off this review. Can you rebase this PR and squash the two commits into one? Once that's done, I'll merge this. Thanks.

@jleeothon
Copy link
Contributor Author

Ack. Let me get home and I'll take care of this.

@benkonrath
Copy link
Member

@jleeothon I rebased this PR and merged it through #179. I added jleeothon to the authors list but I can change it to your real if you want - you just have to give it to me. :) Thanks again for your contribution.

@jleeothon
Copy link
Contributor Author

@benkonrath 😢 I'm so sorry for forgetting to merge this!; I was traveling around a bit. If you have time, my name is Johnny Lee Othon. 😄 Thank you!

@benkonrath
Copy link
Member

@jleeothon No problem. I actually found your name on your github profile and I've already updated the authors list: 6c04870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants