Estonian local flavor: added business registry code field #135
Conversation
|
|
||
| @staticmethod | ||
| def ee_checksum(value): | ||
| return EEPersonalIdentificationCode.ee_checksum(value) |
There was a problem hiding this comment.
First, note that I'm just a contributor and not a committer, so this is just advice at best.
- Personally I don't see any point in creating this shim function, any reason why you want to avoid calling it directly from
clean? - I think the docstring in
EEPersonalIdentificationCode.ee_checksumneeds updating, it should not say "10 digits" any more.
There was a problem hiding this comment.
I created the ee_checksum method there just because EEPersonalIdentificationCode.ee_checksum seemed too long, but you are probably right - it would be clearer if it was explicitly called.
As for the docstring - I totally missed that.
|
Verified against our database of ~2000 companies, works correctly. Other than the minor quibbles, LGTM. Thanks! |
…, fixed ee_checksum docstring
| if not match: | ||
| raise ValidationError(self.error_messages['invalid_format']) | ||
|
|
||
| check = int(match.group(2)) |
There was a problem hiding this comment.
Looking again at this, I think this servers no purpose in business code validation, you might as well use value[7] here and remove the parentheses/groups in the regex.
|
+1 for merge. |
|
@jezdez Can this be merged, please? It's been over 6 months now. |
|
The only blocker I see is lack of |
|
Please merge this. |
|
Sorry for taking so long to merge this. I’ve totally forgotten all about this and github doesn’t send notifications when new commits are added to PRs. Thanks for submitting this, I will merge. |
Estonian local flavor: added business registry code field
|
Thank you for pointing out the no notification thing @nagisa. In the future I will make a comment on such occasions. |
I've added the field to validate the Estonian business registry code (äriregistri registrikood).
Although I couldn't find a standard or a legitimate source for the business registry code structure, it seems to have the same checksum method as the personal identification code. Even though its 8 characters long, the basic math would make sense (just imagine the last 3 non-checksum numbers being 0's). After testing a fair bit of known correct codes, the checksum works.
The
EEBusinessRegistryCodefield itself behaves in a very similar manner to the existingEEPersonalIdentificationCodefield.