Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Czech birth number validation issue #315

Closed
Stranger6667 opened this issue Nov 22, 2017 · 0 comments
Closed

Czech birth number validation issue #315

Stranger6667 opened this issue Nov 22, 2017 · 0 comments

Comments

@Stranger6667
Copy link
Contributor

Stranger6667 commented Nov 22, 2017

As stated in the source code (here)

Three digits for verification number were used until 1. january 1954

And then there is the following condition check:

    if len(id) == 3:
        return '%s' % value

This means, that birth numbers that were issued after 1954.1.1 but don't have fourth digit in it will not be validated. But in fact they are invalid. For example:

Birth number: 600110/0006

This one passes the validation, but if I remove the last digit it will still pass the validation, but it should not because it has to have control digit.

PR: #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant