-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DeprecationWarnings about form default templates #1878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we rendering table rows right now also?
as_table
doesn't render the surrounding <table>
element.
django/forms/utils.py-90- """Render as <tr> elements excluding the surrounding <table> tag."""
django/forms/utils.py-91- return self.render(self.template_name_table)
The HTML generated here isn't correct it seems to me.
Weirdly, during my tests, both |
It's likely because there's no need to render any additional html around a hidden input so both |
Maybe the time has come for us to move to Django 3.2 LTS support ends this April https://www.djangoproject.com/download/ |
Let's confirm there isn't anything wrong with update on fetch with @living180 first. If there isn't, I'm good with dropping 3.2 early. |
Yes, that's a good idea. I have submitted #1880 anyway. |
Description
Improve Django5 compatibility by solving warnings related to form default templates that will change with Django5 from
table
todiv
Fixes # (issue)
#1813
Checklist:
docs/changes.rst
.