Check JavaScript files content type. #1802
Conversation
debug_toolbar/apps.py
Outdated
| Check that JavaScript files are resolving to the correct content type. | ||
| """ | ||
| javascript_types = { | ||
| # Macs |
There was a problem hiding this comment.
Maybe Linux, macOS ? Or Unices ?
There was a problem hiding this comment.
This section confuses me. I put those comments there because on my mac, I found that mimetypes was returning application/javascript, but the windows solution was to use text/javascript.
I couldn't reproduce what windows users would actually experience for this. Or at least not easily.
There was a problem hiding this comment.
I installed python on my windows machine, which was easier than expected. We should check for text/javascript, but we should recommend that users use a value of application/javascript instead. I'll clean this up to reflect that.
A common problem with windows set ups is that the registry is misconfigured when resolving the content type for a JavaScript file. This check captures this sooner to explain why the toolbar doesn't show and attempts to tell the user what to change to make it work.
Co-authored-by: Matthias Kestenholz <[email protected]>
|
@matthiask alright, if you're okay with the latest changes let's merge them. |
|
Yes, thank you! |
A common problem with windows set ups is that the registry is misconfigured when resolving the content type for a JavaScript file. This check captures this sooner to explain why the toolbar doesn't show and attempts to tell the user what to change to make it work.
Fixes #1764
Checklist:
docs/changes.rst.