Fix and improve .assertValidHTML() test method #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the BaseTestCase.assertValidHTML() method was not parsing the content from the provided argument, but was instead parsing self.panel.content. For most usages, the passed in content was the same as self.panel.content, but for the TemplatesPanelTestCase.test_template_repr() test case it was not, resulting in an invalid test.
Allows removal of a call to the internal TestCase._formatMessage() method.
Since the passed in HTML does not necessarily represent the panel content, change the message to no longer reference "Content".
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BaseTestCase.assertValidHTML()helper method was not parsing the passed incontentargument, but insteadself.panel.content. Fix this issue, and also remove themsgargument which was never supplied by any callers. Finally, fix a test case failure exposed by changing the method to parse the suppliedcontent.