Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single source 'djdt' app name #1588

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Conversation

living180
Copy link
Contributor

Avoid needing to keep multiple constants in sync by defining an APP_NAME constant in debug_toolbar.__init__ and referencing where it is needed.

Avoid needing to keep multiple constants in sync by defining an APP_NAME
constant in debug_toolbar.__init__ and referencing where it is needed.
@matthiask
Copy link
Member

Hmm. We stopped single-sourcing the value in ff0b974 because of early importing. But yeah, this way around may work. (The old code imported urls in __init__.)

@living180
Copy link
Contributor Author

Yeah, I hit #1581 as well, and looking at ff0b974, thought it would probably work to flip where the canonical version was stored. All tests passed for me and it didn't cause the #1581 issue to recur in my case.

@matthiask matthiask merged commit 687c289 into django-commons:main Feb 24, 2022
@matthiask
Copy link
Member

Thanks!

@living180 living180 deleted the app_name branch March 7, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants