Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a green flash to new rows in the history table on refresh #1578

Merged
merged 2 commits into from
Feb 19, 2022
Merged

adding a green flash to new rows in the history table on refresh #1578

merged 2 commits into from
Feb 19, 2022

Conversation

gone
Copy link
Contributor

@gone gone commented Jan 17, 2022

I had this refactor left over from the observe ajax work and didn't want to throw it away

@tim-schilling tim-schilling force-pushed the flash-green-refresh-history branch from 8217be7 to 647304c Compare February 19, 2022 15:00
@tim-schilling
Copy link
Member

I renamed array to nodes in pluckData since the argument should be a NodeList instance and added a docstring to try to clarify that for future developers. I also added a mention of the functionality change to the changes documentation. When CI passes, I'll merge it.

matthiask
matthiask approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tim-schilling tim-schilling merged commit 5d03c53 into django-commons:main Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiask matthiask matthiask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gone @tim-schilling @matthiask