-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't raise W006 warning when app loader is specified. #1556
Don't raise W006 warning when app loader is specified. #1556
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1556 +/- ##
==========================================
+ Coverage 86.62% 86.66% +0.03%
==========================================
Files 36 36
Lines 1862 1867 +5
Branches 303 303
==========================================
+ Hits 1613 1618 +5
Misses 175 175
Partials 74 74
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A good side-effect of this is that it annoys people even more who use the toolbar with DEBUG=False
.
It does? |
Co-authored-by: Matthias Kestenholz <[email protected]>
Possibly, if they are using the old pattern of adding the cached Loader when |
From my understanding, if the user specifies any loader, those are the loaders that are used. No additional loaders, including the cached loader will be used. If they don't specify loaders, then Django will specify the filesystem loader, and if app_dirs is True, then the app loader. Then if debug is false it will use the cached loader with whichever are used. Sorry, my brain isn't working at 100%. I'm probably being pedantic. Edit: relevant code: https://github.com/django/django/blob/main/django/template/engine.py#L20-L32 |
Fixes #1550
Thank you @leon-matthews for the report!