Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyupgrade and django-upgrade pre-commit hooks #1553

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

matthiask
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #1553 (3eff33d) into main (8de6921) will not change coverage.
The diff coverage is 69.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1553   +/-   ##
=======================================
  Coverage   86.46%   86.46%           
=======================================
  Files          36       36           
  Lines        1862     1862           
  Branches      303      303           
=======================================
  Hits         1610     1610           
  Misses        178      178           
  Partials       74       74           
Impacted Files Coverage Δ
debug_toolbar/panels/cache.py 78.66% <0.00%> (ø)
debug_toolbar/panels/profiling.py 85.41% <0.00%> (ø)
debug_toolbar/panels/templates/views.py 62.79% <0.00%> (ø)
debug_toolbar/utils.py 76.47% <50.00%> (ø)
debug_toolbar/management/commands/debugsqlshell.py 100.00% <100.00%> (ø)
debug_toolbar/panels/signals.py 86.36% <100.00%> (ø)
debug_toolbar/panels/sql/utils.py 92.15% <100.00%> (ø)
debug_toolbar/panels/sql/views.py 91.04% <100.00%> (ø)
debug_toolbar/panels/templates/panel.py 89.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de6921...3eff33d. Read the comment docs.

@matthiask matthiask force-pushed the mk/pyupgrade-django-upgrade branch from 3895446 to 33ac570 Compare December 16, 2021 11:15
@matthiask matthiask marked this pull request as ready for review December 16, 2021 11:17
Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool!

@matthiask matthiask merged commit 808c8d7 into django-commons:main Dec 17, 2021
@matthiask matthiask deleted the mk/pyupgrade-django-upgrade branch December 17, 2021 08:52
@matthiask
Copy link
Member Author

Thanks!

(I wanted to hold off merging this because of #1542 , but they shouldn't affect each other, I hope.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants