Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a big warning regarding the security implications of changing SHOW_TOOLBAR_CALLBACK #1530

Merged

Conversation

matthiask
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #1530 (dcb59db) into main (d0300b1) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1530      +/-   ##
==========================================
- Coverage   85.87%   85.71%   -0.16%     
==========================================
  Files          35       35              
  Lines        1883     1883              
  Branches      274      274              
==========================================
- Hits         1617     1614       -3     
- Misses        187      190       +3     
  Partials       79       79              
Impacted Files Coverage Δ
debug_toolbar/panels/profiling.py 85.41% <0.00%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0300b1...dcb59db. Read the comment docs.

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Thanks for making this change quickly!

@matthiask matthiask merged commit 1724c4b into django-commons:main Nov 15, 2021
@matthiask matthiask deleted the show-toolbar-callback-warning branch November 15, 2021 19:37
@matthiask
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants