Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract common base cursor wrapper class #1479

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Extract common base cursor wrapper class #1479

merged 1 commit into from
Jun 22, 2021

Conversation

jayaddison
Copy link
Contributor

This change follows on from #1475 and introduces a common base class for cursor wrappers.

This base class is substituted in to the conditional check that identifies whether a cursor is already wrapped by DDT's SQL cursor tracking.

This should be compatible with the test coverage offered in #1478.

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #1479 (eee102e) into main (6ec6bfe) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1479      +/-   ##
==========================================
+ Coverage   86.26%   86.27%   +0.01%     
==========================================
  Files          35       35              
  Lines        1856     1858       +2     
  Branches      261      261              
==========================================
+ Hits         1601     1603       +2     
  Misses        182      182              
  Partials       73       73              
Impacted Files Coverage Δ
debug_toolbar/panels/sql/tracking.py 88.23% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec6bfe...eee102e. Read the comment docs.

@matthiask matthiask merged commit 77bbc8a into django-commons:main Jun 22, 2021
@matthiask
Copy link
Member

Thanks!

@jayaddison
Copy link
Contributor Author

Thank you!

@jayaddison jayaddison deleted the sql-panel/common-base-cursor-class branch June 22, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants