forked from open-telemetry/opentelemetry-collector-contrib
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[receiver/riak] - Fix issue where user configured metric settings wer…
…e ignored (open-telemetry#9561) * empty commit * empty commit * quick fix for newScraper method, e.g. no default * added missing dependencies * make gotidy * added changelog * empty commit, relaunch flaky test * empty commit, rerun tests * added scraper test with some metrics disabled * cleaned up unnecessary tests * implemented recommended changes * removed metricsDisabled boolean from scraper_test * implemented feedback * removed space after newline Co-authored-by: Daniel Jaglowski <[email protected]>
- Loading branch information
1 parent
943044e
commit d098a91
Showing
4 changed files
with
222 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
162 changes: 162 additions & 0 deletions
162
receiver/riakreceiver/testdata/scraper/expected_disabled.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,162 @@ | ||
| { | ||
| "resourceMetrics": [ | ||
| { | ||
| "instrumentationLibraryMetrics": [ | ||
| { | ||
| "instrumentationLibrary": { | ||
| "name": "otelcol/riakreceiver" | ||
| }, | ||
| "metrics": [ | ||
| { | ||
| "description": "The mean time between request and response for operations performed by the node over the last minute.", | ||
| "gauge": { | ||
| "dataPoints": [ | ||
| { | ||
| "asInt": "4", | ||
| "attributes": [ | ||
| { | ||
| "key": "request", | ||
| "value": { | ||
| "stringValue": "get" | ||
| } | ||
| } | ||
| ], | ||
| "startTimeUnixNano": "1648220661611816000", | ||
| "timeUnixNano": "1648220661612587000" | ||
| }, | ||
| { | ||
| "asInt": "5", | ||
| "attributes": [ | ||
| { | ||
| "key": "request", | ||
| "value": { | ||
| "stringValue": "put" | ||
| } | ||
| } | ||
| ], | ||
| "startTimeUnixNano": "1648220661611816000", | ||
| "timeUnixNano": "1648220661612587000" | ||
| } | ||
| ] | ||
| }, | ||
| "name": "riak.node.operation.time.mean", | ||
| "unit": "us" | ||
| }, | ||
| { | ||
| "description": "The number of read repairs performed by the node.", | ||
| "name": "riak.node.read_repair.count", | ||
| "sum": { | ||
| "aggregationTemporality": "AGGREGATION_TEMPORALITY_CUMULATIVE", | ||
| "dataPoints": [ | ||
| { | ||
| "asInt": "0", | ||
| "startTimeUnixNano": "1648220661611816000", | ||
| "timeUnixNano": "1648220661612587000" | ||
| } | ||
| ], | ||
| "isMonotonic": true | ||
| }, | ||
| "unit": "{read_repair}" | ||
| }, | ||
| { | ||
| "description": "The number of index operations performed by vnodes on the node.", | ||
| "name": "riak.vnode.index.operation.count", | ||
| "sum": { | ||
| "aggregationTemporality": "AGGREGATION_TEMPORALITY_CUMULATIVE", | ||
| "dataPoints": [ | ||
| { | ||
| "asInt": "10", | ||
| "attributes": [ | ||
| { | ||
| "key": "operation", | ||
| "value": { | ||
| "stringValue": "read" | ||
| } | ||
| } | ||
| ], | ||
| "startTimeUnixNano": "1648220661611816000", | ||
| "timeUnixNano": "1648220661612587000" | ||
| }, | ||
| { | ||
| "asInt": "11", | ||
| "attributes": [ | ||
| { | ||
| "key": "operation", | ||
| "value": { | ||
| "stringValue": "write" | ||
| } | ||
| } | ||
| ], | ||
| "startTimeUnixNano": "1648220661611816000", | ||
| "timeUnixNano": "1648220661612587000" | ||
| }, | ||
| { | ||
| "asInt": "9", | ||
| "attributes": [ | ||
| { | ||
| "key": "operation", | ||
| "value": { | ||
| "stringValue": "delete" | ||
| } | ||
| } | ||
| ], | ||
| "startTimeUnixNano": "1648220661611816000", | ||
| "timeUnixNano": "1648220661612587000" | ||
| } | ||
| ] | ||
| }, | ||
| "unit": "{operation}" | ||
| }, | ||
| { | ||
| "description": "The number of operations performed by vnodes on the node.", | ||
| "name": "riak.vnode.operation.count", | ||
| "sum": { | ||
| "aggregationTemporality": "AGGREGATION_TEMPORALITY_CUMULATIVE", | ||
| "dataPoints": [ | ||
| { | ||
| "asInt": "7", | ||
| "attributes": [ | ||
| { | ||
| "key": "request", | ||
| "value": { | ||
| "stringValue": "get" | ||
| } | ||
| } | ||
| ], | ||
| "startTimeUnixNano": "1648220661611816000", | ||
| "timeUnixNano": "1648220661612587000" | ||
| }, | ||
| { | ||
| "asInt": "8", | ||
| "attributes": [ | ||
| { | ||
| "key": "request", | ||
| "value": { | ||
| "stringValue": "put" | ||
| } | ||
| } | ||
| ], | ||
| "startTimeUnixNano": "1648220661611816000", | ||
| "timeUnixNano": "1648220661612587000" | ||
| } | ||
| ], | ||
| "isMonotonic": true | ||
| }, | ||
| "unit": "{operation}" | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "resource": { | ||
| "attributes": [ | ||
| { | ||
| "key": "riak.node.name", | ||
| "value": { | ||
| "stringValue": "[email protected]" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ] | ||
| } |