-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Angular 19 Support #167
Conversation
closes #166 |
Note: I did not modify the version of the package. This should be done by a core maintainer before the next release to NPM. |
Hi @EphraimHaber Have you already performed the regression tests for integrating the updated smart table package in an Angular 16, 17, 18 project? |
Hi @uap-universe |
Hi @EphraimHaber
If tests with Angular 17 or 18 fail due to the changes to the code, we must not release the changes as a minor release. The only option would be to introduce a new major release and discard support for older Angular versions. That's more or less the process for every new Angular version :) Now back to my questions: just in case you already did those tests, I don't necessarily need to repeat them. Otherwise, I would need to do them, when I find time. |
Ah ok. Clever. I have not run them. but I'm not sure it's possible to do that given the changes the angular team has made to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The standalone
flag was already present in all still supported Angular versions. So this is good to go to be merged into the next release.
this pr contains the necessary minimal changes to support angular 19.