Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Angular 19 Support #167

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Add Angular 19 Support #167

merged 2 commits into from
Dec 17, 2024

Conversation

EphraimHaber
Copy link

this pr contains the necessary minimal changes to support angular 19.

@EphraimHaber
Copy link
Author

closes #166

@EphraimHaber
Copy link
Author

Note: I did not modify the version of the package. This should be done by a core maintainer before the next release to NPM.

@uap-universe uap-universe self-assigned this Dec 3, 2024
@uap-universe
Copy link
Collaborator

Hi @EphraimHaber
thank you for the PR.

Have you already performed the regression tests for integrating the updated smart table package in an Angular 16, 17, 18 project?

@EphraimHaber
Copy link
Author

Hi @uap-universe
Can you explain please? I've built the .tgz and tested it on a new project. Working nicely as expected.

@uap-universe
Copy link
Collaborator

Hi @EphraimHaber
any change to the code that is necessary to make it compatible with Angular 19 must be also tested with at least all still supported Angular versions, as well.
The tests would be the following:

  • Test with Angular 16 - if it works, we keep it in the list, if it does not, we can remove it, because it is end of life
  • Test with Angular 17 / Angular 18 - must work, because they have not reached end of life

If tests with Angular 17 or 18 fail due to the changes to the code, we must not release the changes as a minor release. The only option would be to introduce a new major release and discard support for older Angular versions.

That's more or less the process for every new Angular version :)

Now back to my questions: just in case you already did those tests, I don't necessarily need to repeat them. Otherwise, I would need to do them, when I find time.

@EphraimHaber
Copy link
Author

Ah ok. Clever. I have not run them. but I'm not sure it's possible to do that given the changes the angular team has made to the @component decorator. I will try and do it by the end of the day.

@uap-universe

@uap-universe uap-universe self-requested a review December 10, 2024 21:26
Copy link
Collaborator

@uap-universe uap-universe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standalone flag was already present in all still supported Angular versions. So this is good to go to be merged into the next release.

@uap-universe uap-universe merged commit 6ab68bd into dj-fiorex:master Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants