Created trusted http client for SSL/TLS and client cert authentication. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added TrustedApacheClient for retrofit (delegation pattern on ApacheClient using custom params for HttpClient) * Added method newTrustedInstance for EtcdClientFactory * Added new constructor for EtcdClientImpl with custom retrofit client * Added test for https and all necessary certificates Why do I override retrofit.client.Client in the jetcd project, not in retrofit? Retrofit already supports SSL/TLS Auth in ApacheClient, but it requires quitely preconfigured apache http client. So, we have to configure apache http client somewhere, for example, in factory class. But there is too much code to initialize ssl apache http client properly. So, I think It well be good idea to hide all this work in the client proxy class TrustedApacheClient and use simple call new TrustedApacheClient(credentials). Credentials object contains client key, client cert and ca cert.
|
Thanks @and-hom! Besides the CI failure (likely due to no running etcd), I do have a few high-level comments about this PR:
What do you think? |
|
Good idea. It's better way to setup setup http client separately, but we have only one configuration of http client to work with etcd. So it may be useful to create an utility for http client ssl/tls setup |
diwakergupta
force-pushed
the
master
branch
3 times, most recently
from
581d5dd to
103a78f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do I override retrofit.client.Client in the jetcd project, not in retrofit? Retrofit already supports SSL/TLS Auth in ApacheClient, but it requires quitely preconfigured apache http client. So, we have to configure apache http client somewhere, for example, in factory class. But there is too much code to initialize ssl apache http client properly. So, I think It well be good idea to hide all this work in the client proxy class TrustedApacheClient and use simple call new TrustedApacheClient(credentials). Credentials object contains client key, client cert and ca cert.