Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Kryo registrations to fix #27 #52

Merged
merged 2 commits into from
Oct 24, 2018
Merged

Add more Kryo registrations to fix #27 #52

merged 2 commits into from
Oct 24, 2018

Conversation

tomwhite
Copy link
Member

Fixes #27, incorporating the extended tests in #44.

@tomwhite tomwhite requested a review from heuermh October 18, 2018 13:43
@tomwhite tomwhite added this to the 0.1.0 milestone Oct 18, 2018
@tomwhite tomwhite mentioned this pull request Oct 23, 2018
Closed
@heuermh heuermh mentioned this pull request Oct 24, 2018
Open
heuermh
heuermh approved these changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@heuermh heuermh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I created issue #55 to follow up on performance implications of using Java serialization for genotypes here.

@heuermh heuermh mentioned this pull request Oct 24, 2018
Closed
@heuermh heuermh merged commit 6a23218 into disq-bio:master Oct 24, 2018
@heuermh
Copy link
Contributor

heuermh commented Oct 24, 2018

Thank you, @tomwhite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heuermh heuermh heuermh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tomwhite @heuermh