[Http4s:middleware] pre and post error handling #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add error handling pre- and post-middleware
Baccata
reviewed
Mar 30, 2023
modules/http4s/src/smithy4s/http4s/internals/SmithyHttp4sServerEndpoint.scala
Outdated
Show resolved
Hide resolved
Baccata
reviewed
Mar 30, 2023
modules/http4s/src/smithy4s/http4s/ServerEndpointMiddleware.scala
Outdated
Show resolved
Hide resolved
|
Let's add additional tests too. |
|
Following some discussion around this, I've decided to wrap this pull request. I've added a test to make sure that if a user implements a middleware that can
Implemented it as such, it made more sense and it match the previous behavior |
Baccata
approved these changes
May 30, 2023
daddykotex
added a commit
that referenced
this pull request
Jun 14, 2023
When merging #877, I introduced a behaviour change that I had not anticipated: the errors defined in the smithy specs were turned into http response before users had a chance to react to them in the middleware they provide this is problematic and this fix reverts that
daddykotex
added a commit
that referenced
this pull request
Jun 14, 2023
When merging #877, I introduced a behaviour change that I had not anticipated: the errors defined in the smithy specs were turned into http response before users had a chance to react to them in the middleware they provide this is problematic and this fix reverts that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added utility function for constructing middleware from partial function as I have seen often enough boilerplate to construct a middleware and the default being identity function , i figure this might be a bit cleaner