Add xml-support [decoder only] #489
Conversation
Add a number of construct that allow for the parsing of XML data into Smithy4s-generated datatypes. The heavy-lifting (parsing) is provided by fs2-data. We interop with it by implementing the `DocumentBuilder` typeclass to create instances of an XmlDocument ADT we control.
| .compile | ||
| .last | ||
| .flatMap(_.liftTo[IO](new Throwable("BOOM"))) | ||
| .map(XmlCursor.fromDocument) |
There was a problem hiding this comment.
thoughts on adding a decoder.readDocument that hides this?
There was a problem hiding this comment.
Dude the PR is still very much a draft, so keep your guns holstered (I'm merely raising it in case in case I get kicked in the head by a horse, so that the code doesn't die with me), but yeah that's where I was heading towards 😄
There was a problem hiding this comment.
my brother in Christ, you asked for the review 
There was a problem hiding this comment.
my brother in Christ, you asked for the review
Nah I said "if you want to have fun", implying that XML is a lot of fun
| schema.compile(this).emap(refinement.asFunction) | ||
|
|
||
| def lazily[A](suspend: Lazy[Schema[A]]): XmlDecoder[A] = new XmlDecoder[A] { | ||
| lazy val underlying: XmlDecoder[A] = suspend.map(compile(_)).value |
There was a problem hiding this comment.
perhaps we can avoid the double lazy (Eval has one built in) and move the .value to inside `read?
There was a problem hiding this comment.
Actually I had tried to remove the double lazy in the json decoder, and it was actually slightly more performant to keep way it was. I was quite surprised by it. I may be wrong, but I think it's because it's may actually hitting to lazy vals on the hotpath.
| hints: Hints, | ||
| alternatives: Vector[SchemaAlt[U, _]], | ||
| dispatch: Alt.Dispatcher[Schema, U] | ||
| ): XmlDecoder[U] = ??? |
There was a problem hiding this comment.
why does CI not complain about these
oh I guess it's because you didn't aggregate the xml module in root
There was a problem hiding this comment.
even so CI wouldn't complain about them I think, because it's not deadcode.
Add a number of construct that allow for the parsing of XML data into Smithy4s-generated datatypes. The heavy-lifting (parsing) is provided by fs2-data. We interop with it by implementing the
DocumentBuildertypeclass to create instances of an XmlDocument ADT we control.NB :