Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Unit primitives when unfolding typed nodes #1325

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add support for Unit primitives when unfolding typed nodes #1325

merged 1 commit into from
Dec 12, 2023

Conversation

denisrosca
Copy link
Contributor

@denisrosca denisrosca commented Dec 12, 2023 •
edited
Loading

Fixes: #1297

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)

Baccata
Baccata approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@Baccata Baccata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Baccata Baccata merged commit 536fbba into disneystreaming:series/0.18 Dec 12, 2023
10 checks passed
@denisrosca denisrosca deleted the unsupported-traits-with-unit branch December 12, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baccata Baccata Baccata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rendering: unsupported traits with sub-components targeting smithy.api#Unit
2 participants
@denisrosca @Baccata