-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose UrlForm.parse and UrlFormDecodeError #1254
Conversation
oops, didn't check the description earlier, thought it was such an obvious change 🤪 I'd say we should update the changelog. Don't know if there's any documentation about forms so far. |
@kubukoz added some docs and the |
Looks like it's failing formatting, can you run |
Interesting! What does it do/what is it used for? Is it URL form data in and JSON out by any chance, or something else? |
@dhpiggott We use this for OKTA (Token Exchange) - that endpoint uses |
At work, we built our own
SimpleUrlFormProtocol
and the implementation mostly reuses what smithy4s already has.However, we had to use runtime reflection to access these bits. Which, IMHO, could (should?) be public.
Let me know what you think and if I should do something else.
PR Checklist