Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose UrlForm.parse and UrlFormDecodeError #1254

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

BalmungSan
Copy link
Contributor

@BalmungSan BalmungSan commented Oct 9, 2023

At work, we built our own SimpleUrlFormProtocol and the implementation mostly reuses what smithy4s already has.
However, we had to use runtime reflection to access these bits. Which, IMHO, could (should?) be public.

Let me know what you think and if I should do something else.


PR Checklist

  • Added unit-tests (already there)
  • Added documentation
  • Updated changelog

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2023

CLA assistant check
All committers have signed the CLA.

@kubukoz
Copy link
Member

kubukoz commented Oct 9, 2023

oops, didn't check the description earlier, thought it was such an obvious change 🤪

I'd say we should update the changelog. Don't know if there's any documentation about forms so far.

@BalmungSan BalmungSan requested a review from kubukoz October 10, 2023 16:57
@BalmungSan
Copy link
Contributor Author

@kubukoz added some docs and the CHANGELOG entry.
Let me know if there is any feedback about those or if I missed something else :)

@kubukoz
Copy link
Member

kubukoz commented Oct 10, 2023

Looks like it's failing formatting, can you run sbt formatAll and commit?

@kubukoz kubukoz merged commit 410478e into disneystreaming:series/0.18 Oct 10, 2023
@BalmungSan BalmungSan deleted the patch-1 branch October 10, 2023 23:10
@dhpiggott
Copy link
Contributor

At work, we built our own SimpleUrlFormProtocol

Interesting! What does it do/what is it used for? Is it URL form data in and JSON out by any chance, or something else?

@mazurio
Copy link

mazurio commented Oct 11, 2023

@dhpiggott We use this for OKTA (Token Exchange) - that endpoint uses x-www-form-urlencoded that accepts grant_type=client_credentials and returns an access_token with scope etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants