DEV: add pnpm compat in preparation of new changes to theme-skeleton #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyb-talks
force-pushed
the
dev-add-pnpm-compatibility
branch
from
595606a to
75c983a
Compare
tyb-talks
commented
Oct 8, 2024
| @@ -0,0 +1,12 @@ | |||
| { | |||
There was a problem hiding this comment.
adding this file is necessary for tests to pass - yarn simply creates empty node_modules and lockfile, but pnpm install would raise an error here. In any case, we should expect the actual theme skeleton repo to always have at least a package.json file.
tyb-talks
commented
Oct 8, 2024
| @@ -36,7 +36,7 @@ Gem::Specification.new do |spec| | |||
| spec.add_development_dependency "guard" | |||
| spec.add_development_dependency "guard-minitest" | |||
| spec.add_development_dependency "webmock" | |||
| spec.add_development_dependency "rubocop-discourse", "~> 3.6.0" | |||
| spec.add_development_dependency "rubocop-discourse", "~> 3.8.1" | |||
There was a problem hiding this comment.
Update required to resolve an earlier error raised in linting CI step.
CvX
approved these changes
Oct 8, 2024
Co-authored-by: Jarek Radosz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are preparing to switch to
pnpmfor all themes/plugins now that the change has landed in core. This change makes the discourse_theme CLI compatible with that change to theme-skeleton. We will remove all usage of yarn in an upcoming minor version bump once pnpm is fully rolled out.For more context: https://meta.discourse.org/t/discourse-core-is-switching-to-pnpm-for-js-package-management/324521