FEATURE: new "notification level when assigned" user preference #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new user preference allowed users to control how the notification level of the topic they're assigned to changes. Internal ref - t/141162
|
Note: the system spec will keep failing until discourse/discourse#30821 is merged. |
ZogStriP
commented
Jan 16, 2025
| @@ -506,6 +508,7 @@ def add_small_action_post(action_code, assign_to, text) | |||
| @assigned_by, | |||
| text, | |||
| bump: false, | |||
| auto_track: false, | |||
There was a problem hiding this comment.
We need this to prevent the "small action" / "whisper" post that is automatically created when assigning a topic from changing the notification level because the user "replied".
ZogStriP
commented
Jan 16, 2025
| constructor(owner, args) { | ||
| super(...arguments); | ||
| if (this.siteSettings.assign_enabled) { | ||
| args.outletArgs.customAttrNames.push("notification_level_when_assigned"); |
There was a problem hiding this comment.
When the plugin is enabled, we add this user option to the list of options that are saved in the /my/preferences/tracking user preferences page.
ZogStriP
commented
Jan 16, 2025
| @@ -860,6 +860,8 @@ export default { | |||
|
|
|||
| api.addUserSearchOption("assignableGroups"); | |||
|
|
|||
| api.addSaveableUserOptionField("notification_level_when_assigned"); | |||
There was a problem hiding this comment.
We need to "globally" allow this user option to be "saveable" when save a user preference's page.
ZogStriP
commented
Jan 16, 2025
| # frozen_string_literal: true | ||
| class AddNotificationLevelWhenAssignedUserOption < ActiveRecord::Migration[7.2] | ||
| def change | ||
| add_column :user_options, :notification_level_when_assigned, :integer, null: false, default: 3 # watch topic |
There was a problem hiding this comment.
Keep the default of "watching" a topic on assign.
keegangeorge
approved these changes
Jan 16, 2025
Co-authored-by: Keegan George <[email protected]>
ZogStriP
added a commit
to discourse/discourse
that referenced
this pull request
Jan 16, 2025
Adds the "user-preferences-tracking-topics" plugin outlet to allow the `discourse-assign` plugin to add a new "notification level when assigned" user preference. There's also a new `customAttrNames` tracked property that allows plugins to add new user option to be saved from this screen / plugin outlet. Also changed the text used for the "notification level when replying" to match the one that is used for the "notification level when assigned" in discourse/discourse-assign#626. ## BEFORE <img width="375" alt="image" src="https://github.com/user-attachments/assets/178ba47e-f783-46d2-adae-28afec49b259" /> ## AFTER <img width="363" alt="Screenshot 2025-01-16 at 16 11 26" src="https://github.com/user-attachments/assets/215e9f86-62f7-48ea-b665-72cbf28abd21" /> DEV: remove unused topic-tracking component
ZogStriP
deleted the
add-notification-level-when-assigned-user-preference
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new user preference allowed users to control how the notification level of the topic they're assigned to changes.
Internal ref - t/141162
Dependent on discourse/discourse#30821 being merged.