FIX: Not send notifications when it should never notify assignment #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added silenced_assignments table and migration to store silenced assignments - Added tests for silenced assignments
markvanlan
reviewed
Dec 12, 2024
| @@ -4,6 +4,7 @@ module Jobs | |||
| class AssignNotification < ::Jobs::Base | |||
| def execute(args) | |||
| raise Discourse::InvalidParameters.new(:assignment_id) if args[:assignment_id].nil? | |||
| return if SilencedAssignment.exists?(assignment_id: args[:assignment_id]) | |||
There was a problem hiding this comment.
The most minor style thing -- empty line under early return (guard clauses) is kinda nice.
markvanlan
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
In PR / commit description can you write a bit more about the conditions in which this was helpful? It's not obvious how this notification is triggered, especially b/c in lib/assigner we see a should_notify variable so you'd expect this to already be taken care of.
Looks great! I would normally say we should clean these up.. Which I guess in the assign notification job you could find, delete, and skip rather than find and skip 🤷 . I'm not too worried about this table ballooning though hehe. And you have an index for lookup.
Grubba27
deleted the
fix/notifications-when-it-should-never-notify-assignment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a
SilencedAssignmenttable, which gets new records whenAssigner#assignis called withshould_notifyas false, which keeps track of assignments that should not have notifications for