MacOS samples #18
Merged
MacOS samples #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discosultan
requested changes
May 27, 2018
There was a problem hiding this comment.
Thanks a ton, @BastianBlokland! MacOS samples are super helpful 🎉
I left a couple notes regarding formatting (tabs vs spaces) but other than that, looking good to me.
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>netcoreapp2.1</TargetFramework> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> |
There was a problem hiding this comment.
mixed tabs and spaces; should be spaces only
| new ClearScreenApp())) | ||
| { | ||
| window.Initialize(); | ||
| window.Run(); |
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>netcoreapp2.1</TargetFramework> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> |
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>netcoreapp2.1</TargetFramework> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> |
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>netcoreapp2.1</TargetFramework> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> |
Samples/Shared/MacOSWindow.cs
Outdated
| private readonly VulkanApp _app; | ||
|
|
||
| private NativeMacOS.NativeApp _nativeApp; | ||
| private NativeMacOS.NativeWindow _nativeWindow; |
Src/VulkanLibrary.cs
Outdated
| { | ||
| handle = LibDLGetProcAddress(_handle, procName); | ||
| } | ||
| else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX)) |
…om the 'libdl' dll import, this way it can load the .dylib on macos, this should still work on linux but havn't tested
…rm' format because 'R5G5B5A1UNormPack16' is not supported on MoltenVK
BastianBlokland
force-pushed
the
macos-samples
branch
from
3a7b155 to
535b4c4
Compare
|
Thanks. Sorry for the tabs, we use tabs at the office and forgot that my editor was set to tabs 😅 Should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic port of the samples to MacOS running on the MoltenVK library. For window-management its using a thin objective-c layer. (source of native obj-c: https://github.com/BastianBlokland/macwindow-dotnet). Nothing close to production ready but it maybe its a start for someone who wants to make a c# vulkan renderer that runs on MacOS.