Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GuildMember): add flags #9087

Merged
merged 2 commits into from
Feb 17, 2023
Merged

feat(GuildMember): add flags #9087

merged 2 commits into from
Feb 17, 2023

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Jan 23, 2023

Please describe the changes this PR makes and why it should be merged:
Upstream:

Depends on:

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Jan 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 9:09PM (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 9:09PM (UTC)

@vercel
Copy link

vercel bot commented Jan 23, 2023

@almeidx is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

@Jiralite Jiralite added this to the discord.js v14.8 milestone Jan 23, 2023
@almeidx almeidx force-pushed the discord.js/guild-member-flags branch from dae9cdd to a8f2e94 Compare January 23, 2023 20:21
@almeidx almeidx force-pushed the discord.js/guild-member-flags branch 2 times, most recently from a8c36e6 to 7fe0756 Compare January 23, 2023 20:23
@Jiralite Jiralite added blocked and removed blocked labels Jan 23, 2023
@jaw0r3k jaw0r3k mentioned this pull request Jan 30, 2023
Merged
kyranet
kyranet reviewed Feb 8, 2023
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else LGTM.

yarn.lock Outdated Show resolved Hide resolved
@almeidx almeidx force-pushed the discord.js/guild-member-flags branch from 1fb2b60 to 7529af8 Compare February 8, 2023 22:49
Jiralite
Jiralite reviewed Feb 17, 2023
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this new property be checked in GuildMember#equals() too?

@Jiralite
Copy link
Member

Blocking this until #9140 is merged.

@Jiralite Jiralite removed the blocked label Feb 17, 2023
@almeidx almeidx force-pushed the discord.js/guild-member-flags branch from 6467268 to 69c1bd0 Compare February 17, 2023 19:31
@almeidx almeidx force-pushed the discord.js/guild-member-flags branch from 69c1bd0 to 4358505 Compare February 17, 2023 20:23
@kodiakhq kodiakhq bot merged commit 76b2116 into discordjs:main Feb 17, 2023
@almeidx almeidx deleted the discord.js/guild-member-flags branch February 17, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

Assignees
No one assigned
Labels
api support packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js 14.8
Development

Successfully merging this pull request may close these issues.
5 participants
@almeidx @Jiralite @vladfrangu @kyranet @SpaceEEC