-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ThreadChannel): add a helper for pin and unpin #8786
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Co-authored-by: Jiralite <[email protected]>
Co-authored-by: Jiralite <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #8786 +/- ##
==========================================
+ Coverage 85.22% 85.61% +0.38%
==========================================
Files 77 96 +19
Lines 6715 9459 +2744
Branches 877 1134 +257
==========================================
+ Hits 5723 8098 +2375
- Misses 953 1319 +366
- Partials 39 42 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, probably shouldn't be mutating the flags bit field like that (in case of failure, etc)
Something like this should do the trick
Co-authored-by: Aura Román <[email protected]>
@kyranet do I edit types for |
ah you said except that one mb |
I meant that all the other methods have the correct return type based on I personally don't mind changing it, but it's also out of this PR's scope, feel free to create a new one. This PR is fine as-is. |
should I add a note saying that only forum threads can be pinned? |
Good catch, please do so @Idris1401. |
also isn't this why |
Please describe the changes this PR makes and why it should be merged:
With the help of @monbrey and @almeidx.
Status and versioning classification:
Please move lines that apply to you out of the comment: