feat: proxy container #8000
Merged
feat: proxy container #8000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
didinele
force-pushed
the
feat/proxy-container
branch
2 times, most recently
from
adb323e to
93f42d3
Compare
S222em
reviewed
Jun 4, 2022
didinele
force-pushed
the
feat/proxy-container
branch
from
dd66b50 to
486974d
Compare
didinele
force-pushed
the
feat/proxy-container
branch
from
6f83219 to
90f94a9
Compare
didinele
force-pushed
the
feat/proxy-container
branch
from
90f94a9 to
7737702
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
iCrawl
reviewed
Jun 11, 2022
iCrawl
reviewed
Jun 11, 2022
iCrawl
reviewed
Jun 11, 2022
iCrawl
reviewed
Jun 11, 2022
iCrawl
reviewed
Jun 11, 2022
kyranet
reviewed
Jun 11, 2022
|
Meant in the container, taken care of. |
kyranet
previously requested changes
Jun 11, 2022
Co-authored-by: A. Román <[email protected]>
vladfrangu
previously requested changes
Jun 12, 2022
vladfrangu
approved these changes
Jun 13, 2022
iCrawl
reviewed
Jun 13, 2022
iCrawl
reviewed
Jun 13, 2022
iCrawl
approved these changes
Jun 13, 2022
kyranet
approved these changes
Jun 16, 2022
This comment was marked as spam.
This comment was marked as spam.
SpaceEEC
approved these changes
Jun 17, 2022
This was referenced Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
As the next step to #7925, this PR introduces another "package" (it's more of a container), with the purpose of being an easy-to-deploy HTTP proxy built on top of
@discordjs/proxyAdditionally, this PR:
@discordjs/proxy, since apparentlyerror.messagewould contain "unsupported characters"populateAbortErrorResponse(apparently it had no doc comment, something that was missed from feat: @discordjs/proxy #7925, oops)proxyRequestsnow properly forwardsContent-Type, no longer causing errors on non-GET requestsTODO: