Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Replace Moq with NSubstitute for Mocking in GuildHelperTests #2754

Merged
merged 3 commits into from
Nov 18, 2023
Merged

[Refactor] Replace Moq with NSubstitute for Mocking in GuildHelperTests #2754

merged 3 commits into from
Nov 18, 2023

Conversation

DeclanFrampton
Copy link
Contributor

@DeclanFrampton DeclanFrampton commented Aug 10, 2023 •
edited
Loading

Refactored test suite in the GuildHelperTests class to utilize the NSubstitute mocking library instead of Moq.

Changes:

  • Replaced Moq with NSubstitute for test mock setup.
  • Updated assertions to NSubstitute assertion syntax.
  • Removed redundant assignment of 'output' parameter in test constructors.

Closes: #2747
Additional References: https://github.com/moq/moq/issues/1372

@quinchs quinchs enabled auto-merge (squash) November 18, 2023 20:54
@quinchs quinchs merged commit b988a18 into discord-net:dev Nov 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinchs quinchs quinchs approved these changes

@reecebenson reecebenson reecebenson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Moq with NSubstitute (wtf kzu?)
3 participants
@DeclanFrampton @reecebenson @quinchs