Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): fixed inline margins in text blocks #661

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

makhnatkin
Copy link
Contributor

@makhnatkin makhnatkin commented Mar 6, 2025

This PR fixes vertical margin issues in blockquote and other text blocks.

Changes:

  1. Original styles (margin: 0 0 15px) were replaced with margin-block: var(--yfm-text-block-margin-block, 0 15px) (see PR #648).
  2. Missed that blockquote margins were reset; added margin-inline: var(--yfm-text-block-margin-inline, 0) to fix it.

Before and After

Before: Wide spacing in blockquote.
Screenshot 2025-03-06 at 12 05 55

After: Consistent vertical margins restored.
Screenshot 2025-03-06 at 12 06 05

@makhnatkin makhnatkin requested review from shevnv and 3y3 March 6, 2025 11:23
@makhnatkin makhnatkin merged commit 0acf6bb into master Mar 6, 2025
1 check passed
@makhnatkin makhnatkin deleted the fix/blockquote-margin branch March 6, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants