Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queued spawn #6

Merged
merged 5 commits into from
Sep 19, 2014
Merged

Queued spawn #6

merged 5 commits into from
Sep 19, 2014

Conversation

bmeck
Copy link
Contributor

@bmeck bmeck commented Sep 18, 2014

fixes #5

this uses process-queue in order to allow for some other business requirements I had such as being able to change the spawning function (for remote spawning), and logging the processes.

@diosney
Copy link
Owner

diosney commented Sep 19, 2014

Nice! Thanks! 😄

Later, I will change some code styling on var names to maintain the same overall code style, I hope you don't mind :)

diosney added a commit that referenced this pull request Sep 19, 2014
* Added queued spawn support to prevent XTables concurrency fail lock.
* Added an `iptables.dump` method to parse out `iptables-save`.
* Added an `iptablables.check` method to check the existence one or more rules from the selected chain.
@diosney diosney merged commit 74c6501 into diosney:master Sep 19, 2014
@bmeck
Copy link
Contributor Author

bmeck commented Sep 19, 2014

changing it is fine, might also want to change the undocumented cmdQueue
option to something that fits your style.

On Fri, Sep 19, 2014 at 9:35 AM, Diosney Sarmiento <[email protected]

wrote:

Merged #6 #6.


Reply to this email directly or view it on GitHub
#6 (comment).

@diosney
Copy link
Owner

diosney commented Sep 19, 2014

Great!

Also, there was a dependency that was giving errors on install, namely offspring, I removed it from package.json and everything was smoothly.

@diosney
Copy link
Owner

diosney commented Sep 29, 2014

@bmeck: I finished the revision, added several basic tests (which was due long ago), and released a new version with the changes.

If you find anything is missing or wrong just tell.

BTW: I changed cmdQueue to only be queue and deprecated the specific .comment in favor of the generic matches approach, hope you don't mind.

And again, thanks for your help, it is more than welcomed :D

@bmeck
Copy link
Contributor Author

bmeck commented Sep 29, 2014

seems fine. +1

On Sun, Sep 28, 2014 at 8:34 PM, Diosney Sarmiento <[email protected]

wrote:

@bmeck https://github.com/bmeck: I finished the revision, added several
basic tests (which was due long ago), and released a new version with the
changes.

If you find anything is missing or wrong just tell.

BTW: I changed cmdQueue to only be queue and deprecated the specific
.comment in favor of the generic matches approach, hope you don't mind.

And again, thanks for your help, it is more than welcomed :D


Reply to this email directly or view it on GitHub
#6 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement queueing
2 participants