Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "can" type, and "bitrate" property #10

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

cordellcalitz
Copy link
Contributor

Thanks for the great node module!

I would like to use this on an embedded system to configure the CAN ports on the fly without needing to exec ip commands, but I found that I could not set "can" type devices and "bitrate" was not supported.

A typical command to configure a can port would look something like this:
sudo ip link set can0 type can bitrate 125000

I tested my changes locally and it seems to do the trick.

Please let me know if you would like me to spin the version in this PR or if you will do that before publishing?

@diosney
Copy link
Owner

diosney commented Jun 17, 2024

Hi! Thank you for using the library and doing the PR.

I'm going to merge it, make several changes like add the rest of can options and publish a new version, which should be finished by tomorrow.

Thanks again!

@diosney diosney merged commit dc64993 into diosney:master Jun 17, 2024
3 checks passed
@diosney
Copy link
Owner

diosney commented Jun 17, 2024

I added the rest of the parameters and published 2.2.0.

Check 1e07a12 in case that you want to confirm them.

@cordellcalitz
Copy link
Contributor Author

Great, thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants