-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request/suggestion #99
Comments
Possibly I'll look into it. PhotoSwipe needs to override the default touch events to work effectively which is preventing the default "save as" dialog |
It's February, 2012 and it seems this feature hasn't made it in as of yet. Any feedback on the matter would be appreciated. |
+1 Should be nice to have the possibility of the "Save As" functionnality |
+1 |
2 similar comments
+1 |
+1 |
So 5 years later, this function is still broken? |
+1 |
1 similar comment
+1 |
Can some beer money be thrown somewhere to get this looked into? It's a deal-breaker for me, but everything else about this plugin is perfect. |
I still miss this default long press behavior. body .pswp__img { But in Safari I can't solve this problem, sadly. |
@capuski I have made some modifications and encapsulation to photoswipe in the past few days , and it seems that I have fixed the problem that we can't save image through long press in safari. Maybe you can take a look , https://github.com/JayWii/Photoswipe-package |
@JayWii I tested the demo page in IOS and it worked perfectly (Safari and Chrome). I will implement it. Thank you so much! |
@JayWii have you changed a lot of the plugin? I noticed some changes in how you interact with the open photo. There is no hiding the top and bottom bars (close and caption). I consider this property very important because it allows you to view the photo in real full screen. Is there anything more significant that you have changed in the plugin? |
@capuski Thanks for your feedback, i have not changed a lot of the plugin, just about long press save in Safari . About the question of 'no hiding the top and bottom bars', when you set // JS
var options = {
closeEl: true,
tapToClose: false,
topBarEl: true
}
PhotoPackage.init(imageArr, '.img-selector', options); Vue-component is also support, you can check the readme. |
@JayWii Great. I will take a look with more attention. Thank you again :) |
@JayWii Can I use your script without changing my JS calls? My site Scripts are a little bit complex to me, lots of functions calling functions. And I use cash plugins that complicate even more. |
@capuski Of course, you don't have to use my plugin, you can find a script |
@JayWii Strange because I just replace the |
@capuski sorry, it's my fault, i uploaded a wrong file and I have just reposted it correctly, you can try again. btw, I'm going to bed. Good night & Good Luck |
@JayWii Thank you so much for your help and attention. Implementing just de Videos: https://drive.google.com/drive/folders/1dmBzPgZ91RSq58jCkLgGV9U1u_a99pcK?usp=sharing |
@capuski maybe you need FastClick.js. I guess。。。 |
Safari on iPad has the feature that if you tap and hold an image you can save it. This seems to work only if you do that to an img element (though I haven't thoroughly checked that). In the photoswipe image gallery this doesn't work as you are hovering over something else apparently. Would it be possible to modify photoswipe accordingly? Would be really cool if you could save images that way.
The text was updated successfully, but these errors were encountered: