Excluded analytix/js/cta_forms from requirejs build #35767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
This is followup for #35729
The
import
statement added to cta_forms.js here breaks requirejs's parser. That file, as part of analytics, is in thebase_main
bundle, even though it's only needed on pre-login pages where the demo button is displayed.This PR tells requirejs to ignore that file when bundling. There's probably some minor performance implication to this, but we only have ~10 pages left on requirejs, so I'm not concerned.
Safety Assurance
Safety story
This change primarily affects the deploy process. I've deployed to staging and tested that the signup workflow with the telephone widget still works properly, and I've smoke tested that the "Current Subscription" page (one of the few remaining requirejs pages) loads without doing anything wonky.
Automated test coverage
no
QA Plan
no
Rollback instructions
Labels & Review