Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded analytix/js/cta_forms from requirejs build #35767

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

orangejenny
Copy link
Contributor

Technical Summary

This is followup for #35729

The import statement added to cta_forms.js here breaks requirejs's parser. That file, as part of analytics, is in the base_main bundle, even though it's only needed on pre-login pages where the demo button is displayed.

This PR tells requirejs to ignore that file when bundling. There's probably some minor performance implication to this, but we only have ~10 pages left on requirejs, so I'm not concerned.

Safety Assurance

Safety story

This change primarily affects the deploy process. I've deployed to staging and tested that the signup workflow with the telephone widget still works properly, and I've smoke tested that the "Current Subscription" page (one of the few remaining requirejs pages) loads without doing anything wonky.

Automated test coverage

no

QA Plan

no

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@orangejenny orangejenny added the product/invisible Change has no end-user visible impact label Feb 12, 2025
@orangejenny orangejenny requested a review from biyeun as a code owner February 12, 2025 19:18
@orangejenny orangejenny merged commit 011c2ea into master Feb 12, 2025
13 checks passed
@orangejenny orangejenny deleted the jls/requirejs-ignore-hubspot branch February 12, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants