Fix inline code styling when in a link #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattIPv4
force-pushed
the
MattIPv4/fix-code-in-link
branch
from
1f3049a to
d8c25d1
Compare
erhilse
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
What issue does this relate to?
N/A
What should this PR do?
Fix the styling of inline code that is within a link, so that the text in the inline code is visible while the link is being hovered. To allow for the code background and the link background to layer properly alongside the code text, I switched the background on inline code elements to being a pseudo-element, so I can layer it behind the background of the link.
Also, while I was here, I tweaked the alignment of the copy button in code blocks using Prism, as it looked rather off-center vertically in code blocks that had a single line of code.
What are the acceptance criteria?
Links on their own continue to look visually correct.
Inline code on its own continues to look visually correct.
Inline code with a variable inside continues to look visually correct.
Links with inline code inside continue to look visually correct.
Code blocks continue to look visually correct.