Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1199: Add notify #1277

Merged
merged 9 commits into from
Feb 27, 2024
Merged

1199: Add notify #1277

merged 9 commits into from
Feb 27, 2024

Conversation

ztefanie
Copy link
Member

@ztefanie ztefanie commented Feb 7, 2024

Short description

Add notify command and end all jobs with it.

Notify only works if the toolbelt was installed successfully.
The toolbelt is only notifying if it was a main branch or if it is a branch starting with "release-" and the "allow-all-branches" flag is set.

Resolved issues

Fixes: #1199

@ztefanie ztefanie force-pushed the 1199-add-mattermost-notifications branch 4 times, most recently from c7a06cc to 66ec574 Compare February 7, 2024 07:49
@ztefanie ztefanie force-pushed the 1199-add-mattermost-notifications branch from 66ec574 to 394cbe7 Compare February 7, 2024 08:01
@ztefanie ztefanie force-pushed the 1199-add-mattermost-notifications branch 8 times, most recently from f12da27 to 92f8792 Compare February 26, 2024 13:40
@ztefanie ztefanie force-pushed the 1199-add-mattermost-notifications branch from 92f8792 to 43bb768 Compare February 26, 2024 13:41
@ztefanie ztefanie marked this pull request as ready for review February 26, 2024 13:42
.circleci/src/commands/notify.yml Show resolved Hide resolved
.circleci/src/jobs/check.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question because i didn't find it in the code @ztefanie
Is there also a notification for successful release? because it was mentioned in #1199 or will there be a separate pr

@ztefanie
Copy link
Member Author

Just one question because i didn't find it in the code @ztefanie Is there also a notification for successful release? because it was mentioned in #1199 or will there be a separate pr

yes there will be a separate PR, i will open a ticket for this. We need the release-notes parsing first.

Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done :)

@ztefanie ztefanie enabled auto-merge February 27, 2024 12:56
@ztefanie ztefanie merged commit 03a0499 into main Feb 27, 2024
1 check passed
@ztefanie ztefanie deleted the 1199-add-mattermost-notifications branch February 27, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mattermost notifications
3 participants