Improved the validation error messages on export template parsing #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparkhi
added a commit
that referenced
this pull request
Jun 26, 2024
* some documentation update * [maven-release-plugin] prepare release droid-6.8.0-RC1 * [maven-release-plugin] prepare for next development iteration * Export dialog minimum size reduced and tooltip made multiline (#1110) * > not allowed in javadoc * [maven-release-plugin] prepare release droid-6.8.0-RC2 * [maven-release-plugin] prepare for next development iteration * Improved the validation error messages on export template parsing (#1113) * Improved the validation error messages on export template parsing * Updated documentation for csv columns in relation to export template * Updated cxf version due to underlying vulnerability * Updated changelog * [maven-release-plugin] prepare release droid-6.8.0-RC3 * [maven-release-plugin] prepare for next development iteration * Updated to latest JRE, increased max memory and updated docs to reflect the changes (#1115) * Updated to latest JRE, increased max memory and updated docs to reflect the changes * Case corrected for Megabytes * Removed appveyor build status icon * Minor text correction * [maven-release-plugin] prepare release droid-6.8.0 * [maven-release-plugin] prepare for next development iteration --------- Co-authored-by: Saurabh Parkhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging the error message improvements into the release branch
The main change is,
Earlier the order of checks was
Now we have changed the checking order between 2 and 3, this means "anything else" is treated as a constant string column and automatically, the associated error messages indicate syntax error accordingly