UI minor bugs #1101
Merged
UI minor bugs #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few Ux bugs (some long standing, some recent) are fixed
Cancelling the "Preferences" dialog was not resetting the changes on the dialog - this might have been a long standing source of confusion for many people around the issue of "hash not generated"
Whether to launch a new profile or not is decided by a few properties, there should have been signature files in that list, instead there was signature file URL
Cancelling the "Do you want to create a new profile?" question and then cancelling the preferences dialog was still setting the response code to be OK causing another issue in a specific situation (might have been masked by 1 above)