Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded dependency (jetty-servlet) #14

Closed
stevewalton28 opened this issue Jan 21, 2020 · 1 comment
Closed

Remove unneeded dependency (jetty-servlet) #14

stevewalton28 opened this issue Jan 21, 2020 · 1 comment
Assignees
@stevewalton28
Labels
bug Something isn't working

Comments

@stevewalton28
Copy link
Contributor

We probably don't need jetty-servlet as we are serving resources in the integration tests not servlets
@stevewalton28 stevewalton28 self-assigned this Jan 21, 2020
@stevewalton28 stevewalton28 added the bug Something isn't working label Jan 21, 2020
stevewalton28 added a commit that referenced this issue Jan 21, 2020
@stevewalton28
Big changeset here:
588b4ac 
Features/fixes/changes:
- BaseAbstractTest - amended to as the config is now a singleton
- u.c.e.w.configuration.Configured* - added interface and implementations for each driver to allow us to use the grid configuration that comes from the config file and only to download the binaries if we're local
- ConfigurationLoader - removed some of the options for the builder so we can use it in the TestConfigManager singleton
- TestConfigManger - a singleton to make the configuration available anywhere and to only have one instance of it
- GridConfig - data model to represent the object in the config file
- RunType - enum for local or grid runs
- WebDriverConfig - some additiona fields for exception tolerance, grid, run type and generic test config
- ClickUtils - a tolerant click that handles the exceptions passed in the config file and retries once
- RadioButtonUtils - methods to select radio buttons by visible labels
- JavaScriptUtils - added method to handle running javascript on a specific WebElement
- WindowUtils - added scrollIntoView method (which uses new methods in JavaScriptUtils)
- SelectBoxUtils - making itemByIndex work not on 0 based numbers (so that the argument can be presented logically i.e. 1 instead of 0)
- WebDriverBuilder - refactored after the introduction of ConfgiuredDrivers and a TestConfigManager
- WebDriverListener - a few fixes for screenshots - found issue #13 here
- Dates - added a method for getting todays date

Test (see issue #7):
- Added more unit tests
- Added integration tests for browser driver loading locally - these tests are platorm dependant (mac or windows) because of the browsers. They depend on the browsers being installed
- Added integration test for the helper utilities
- Added a small sample web app that is embedded with jetty to allow us to have a sample HTML page to test the helper utilites in bad situations, this is still WIP, and is dependant on port 4442 being open.

Dependencies:
- Added jetty-server and jetty-servlet (probably need to remove jetty-servlet (see issue #14)
- Added surefire plugin to run integration tests - these can now be ran on `mvn verify`
@stevewalton28 stevewalton28 mentioned this issue Jan 21, 2020
Merged
stevewalton28 added a commit that referenced this issue Jan 22, 2020
@stevewalton28
Resolving issue #14 - removing unused dependency from pom - jetty-ser…
e81ed3d 
…vlet
@stevewalton28 stevewalton28 mentioned this issue Jan 22, 2020
Merged
@stevewalton28
Copy link
Contributor Author

Resolved - for release in 0.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevewalton28 stevewalton28

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevewalton28