Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

participant-integration-api: Remove limitMaxCommandsInFlight. [KVL-1009] #10626

Merged
merged 1 commit into from
Aug 20, 2021
Merged

participant-integration-api: Remove limitMaxCommandsInFlight. [KVL-1009] #10626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ledger/participant-integration-api/src/main/scala/platform/apiserver/ApiServices.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@ private[daml] object ApiServices {
ledgerId,
commandConfig.inputBufferSize,
commandConfig.maxCommandsInFlight,
commandConfig.limitMaxCommandsInFlight,
commandConfig.retentionPeriod,
),
// Using local services skips the gRPC layer, improving performance.
Expand Down
15 changes: 5 additions & 10 deletions ...cipant-integration-api/src/main/scala/platform/apiserver/services/ApiCommandService.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,15 +139,11 @@ private[apiserver] final class ApiCommandService private (
ledgerEnd,
() => ledgerConfig.maxDeduplicationTime,
)
val trackingFlow =
if (configuration.limitMaxCommandsInFlight)
MaxInFlight(
configuration.maxCommandsInFlight,
capacityCounter = metrics.daml.commands.maxInFlightCapacity(metricsPrefixFirstParty),
lengthCounter = metrics.daml.commands.maxInFlightLength(metricsPrefixFirstParty),
).joinMat(tracker)(Keep.right)
else
tracker
val trackingFlow = MaxInFlight(
configuration.maxCommandsInFlight,
capacityCounter = metrics.daml.commands.maxInFlightCapacity(metricsPrefixFirstParty),
lengthCounter = metrics.daml.commands.maxInFlightLength(metricsPrefixFirstParty),
).joinMat(tracker)(Keep.right)
TrackerImpl(
trackingFlow,
configuration.inputBufferSize,
Expand Down Expand Up @@ -247,7 +243,6 @@ private[apiserver] object ApiCommandService {
ledgerId: LedgerId,
inputBufferSize: Int,
maxCommandsInFlight: Int,
limitMaxCommandsInFlight: Boolean,
retentionPeriod: FiniteDuration,
)

Expand Down
4 changes: 0 additions & 4 deletions ...ticipant-integration-api/src/main/scala/platform/configuration/CommandConfiguration.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ import scala.concurrent.duration.{DurationInt, FiniteDuration}
* transaction has been shipped via the WriteService.
* @param maxCommandsInFlight
* Maximum number of submitted commands waiting to be completed for each party.
* @param limitMaxCommandsInFlight
* Whether [[maxCommandsInFlight]] should be honored or not.
* @param retentionPeriod
* For how long the command service will keep an active command tracker for a given party.
* A longer retention period allows to not instantiate a new tracker for a party that seldom acts.
Expand All @@ -30,7 +28,6 @@ final case class CommandConfiguration(
inputBufferSize: Int,
maxParallelSubmissions: Int,
maxCommandsInFlight: Int,
limitMaxCommandsInFlight: Boolean,
retentionPeriod: FiniteDuration,
)

Expand All @@ -42,7 +39,6 @@ object CommandConfiguration {
inputBufferSize = 512,
maxParallelSubmissions = 512,
maxCommandsInFlight = 256,
limitMaxCommandsInFlight = true,
retentionPeriod = DefaultTrackerRetentionPeriod,
)
}