Ej/fix router #12
Closed
Ej/fix router #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSin
requested changes
Apr 3, 2023
There was a problem hiding this comment.
Lets scope this work a little tighter. If you are just changing the router. Lets point it to develop and only change the router, not add any new screens/themes/layouts/views.
I think the easiest thing would be to close this PR. and then start a new PR based off develop, and only touch the router files.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it turns out reach-router doesn't really support electron. Whilst in theory there's a workaround I didn't really work for me.
Reach router has been quietly deprecated for a couple of years now and it's maintainers now work on React router, figured it's worthwhile moving over. And it seems to work so thats good.