Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(Chip.Checkbox): use small border radius #3167

Merged
merged 1 commit into from
Feb 19, 2025
Merged

style(Chip.Checkbox): use small border radius #3167

merged 1 commit into from
Feb 19, 2025

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Feb 18, 2025 •
edited
Loading

figma sync

@Barsnes Barsnes marked this pull request as ready for review February 18, 2025 13:34
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: 8a7038d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

Preview deployments for this pull request:

Storybook - 18. Feb 2025 - 14:36

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 50.33% 3206 / 6369
🔵 Statements 50.33% 3206 / 6369
🔵 Functions 85.31% 215 / 252
🔵 Branches 77.93% 558 / 716
File CoverageNo changed files found.
Generated in workflow #2121 for commit 8a7038d by the Vitest Coverage Report Action

mimarz
mimarz approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its off by one according to border and Checkbox but visually better due to Chip being so small

@Barsnes Barsnes merged commit 35e1d60 into next Feb 19, 2025
13 checks passed
@Barsnes Barsnes deleted the chip/border-rad-inpu-chck branch February 19, 2025 07:56
mimarz pushed a commit that referenced this pull request Feb 21, 2025
@Barsnes @mimarz
style(Chip.Checkbox): use small border radius (#3167)
37f62d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

@oddvernes oddvernes Awaiting requested review from oddvernes oddvernes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Barsnes @mimarz