Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added primitives prefix to all sets within primitives #3152

Open
wants to merge 7 commits into
base: next
Choose a base branch
from
Open

chore: added primitives prefix to all sets within primitives #3152

wants to merge 7 commits into from

Conversation

Febakke
Copy link
Member

@Febakke Febakke commented Feb 14, 2025

resolves: #2886

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: ad5da59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet Patch
@digdir/designsystemet-css Patch
@digdir/designsystemet-theme Patch
@digdir/designsystemet-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025 •
edited
Loading

Preview deployments for this pull request:

Storybook - 18. Feb 2025 - 12:11

Storefront - 18. Feb 2025 - 12:12

@mimarz mimarz changed the title chore: Added primitives prefix to all sets within primitives chore: added primitives prefix to all sets within primitives Feb 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 50.33% 3206 / 6369
🔵 Statements 50.33% 3206 / 6369
🔵 Functions 85.31% 215 / 252
🔵 Branches 77.93% 558 / 716
File CoverageNo changed files found.
Generated in workflow #2106 for commit ad5da59 by the Vitest Coverage Report Action

@mimarz mimarz marked this pull request as draft February 17, 2025 10:19
@mimarz mimarz marked this pull request as ready for review February 17, 2025 12:49
@mimarz mimarz requested a review from oddvernes as a code owner February 17, 2025 12:49
@mimarz mimarz requested a review from unekinn February 17, 2025 13:11
@mimarz mimarz force-pushed the clearer-name-on-primitive-tokens branch from 1ed37dc to 1abe2f1 Compare February 17, 2025 14:03
mimarz
mimarz requested changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After self reviewing, I think we need to do some changes to best support this as currently we have a mix of semantic and primitives tokens being exposed.

@mimarz mimarz mentioned this pull request Feb 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz requested changes

@Barsnes Barsnes Barsnes approved these changes

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

@oddvernes oddvernes Awaiting requested review from oddvernes oddvernes is a code owner

@unekinn unekinn Awaiting requested review from unekinn

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clearer naming and separation of non-semantic design tokens
3 participants
@Febakke @mimarz @Barsnes