fix: ref type on useCheckboxGroup and useRadioGroup
#3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 99d66ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: Storybook - |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
mimarz
changed the title
ref type on useCheckboxGroup and useRadioGroupref type on useCheckboxGroup and useRadioGroup
eirikbacker
reviewed
Feb 7, 2025
Barsnes
approved these changes
Feb 10, 2025
mimarz
added a commit
that referenced
this pull request
Feb 21, 2025
Fixes bug reported in by slack, when using our `useCheckboxGroup` and
`useRadioGroup` with respective `Checkbox` and `Radio` component.
This was probably due to changes in types used for `forwardRef` in React
19.
```sh
Type '{ name?: string | undefined; title?: string | undefined; description?: ReactNode; placeholder?: string | undefined; form?: string | undefined; onChange?: ChangeEventHandler<HTMLInputElement> | undefined; ... 288 more ...; label: string; }' is not assignable to type 'RefAttributes<HTMLInputElement>'.
Types of property ref are incompatible.
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug reported in by slack, when using our
useCheckboxGroupanduseRadioGroupwith respectiveCheckboxandRadiocomponent.This was probably due to changes in types used for
forwardRefin React 19.