Replace auto-generated typography classes with CSS variables #2392
Assignees
Labels
Milestone
Comments
mimarz
added
$ tokens
mimarz
added a commit
that referenced
this issue
Sep 17, 2024
mimarz
added a commit
that referenced
this issue
Sep 17, 2024
mimarz
added a commit
that referenced
this issue
Sep 19, 2024
mimarz
added a commit
that referenced
this issue
Sep 19, 2024
resolves #2392 - Removed `typography` in name from typography CSS variables (This touched a lot of files). - Removed generated CSS classes. - Replaced with deconstructed CSS variable for each prop. - Replicated current classes with new CSS variables to make sure everything was still working. -⚠️ Paragraph typography variants, `short` & `long` needs to be separate classes to support `@composes` as it colides with other components `variant`. - For example `Button` `variant`. - I would think this is a minor tradeoff. - Saving rewrite of typography classes to new CSS convention for separate PR as this is big enough. - Concatenated `base` layer with `utilities` and `typography` Look at "old" changes in commit 2e0c899 on how `Button` and `Paragraph` can be updated to follow the new convention.
github-project-automation
bot
moved this from 👀 Ready for review
to ✅ Done
in Team Designsystemet
mimarz
added a commit
that referenced
this issue
Feb 21, 2025
resolves #2392 - Removed `typography` in name from typography CSS variables (This touched a lot of files). - Removed generated CSS classes. - Replaced with deconstructed CSS variable for each prop. - Replicated current classes with new CSS variables to make sure everything was still working. -⚠️ Paragraph typography variants, `short` & `long` needs to be separate classes to support `@composes` as it colides with other components `variant`. - For example `Button` `variant`. - I would think this is a minor tradeoff. - Saving rewrite of typography classes to new CSS convention for separate PR as this is big enough. - Concatenated `base` layer with `utilities` and `typography` Look at "old" changes in commit 2e0c899 on how `Button` and `Paragraph` can be updated to follow the new convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In an effort to remove "hidden" linking between typography classes and brittle code we will remove the autogenerated typography classes and instead use the default css variables for typgraphy composite tokens.
We will need to update/remove the SD (Style Dictionary) format and config for Typography in
packages/cli/src/tokens/buildThe text was updated successfully, but these errors were encountered: