-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: dynamically parse the latest/actual release version when building docs #312
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,8 @@ | |
from importlib.metadata import version | ||
from pathlib import Path | ||
|
||
import requests | ||
|
||
# If extensions (or modules to document with autodoc) are in another directory, | ||
# add these directories to sys.path here. If the directory is relative to the | ||
# documentation root, use Path().resolve() to make it absolute, like shown here. | ||
|
@@ -68,11 +70,30 @@ | |
# |version| and |release|, also used in various other places throughout the | ||
# built documents. | ||
|
||
|
||
def _get_latest_release_from_github(org: str, repo_name: str) -> str: | ||
"""Get the highest version release (including prereleases) from GitHub | ||
repository.""" | ||
url = f"https://api.github.com/repos/{org}/{repo_name}/releases" | ||
response = requests.get(url) | ||
releases = response.json() | ||
valid_releases = [release for release in releases if "tag_name" in release] | ||
if not valid_releases: | ||
return "No valid releases found" | ||
latest_version_release = valid_releases[0]["tag_name"] | ||
return latest_version_release | ||
|
||
|
||
# Get the latest release version from GitHub repository | ||
org = "diffpy" | ||
repo_name = "diffpy.utils" | ||
latest_verion_from_github = _get_latest_release_from_github(org, repo_name) | ||
|
||
fullversion = version(project) | ||
# The short X.Y version. | ||
version = "".join(fullversion.split(".post")[:1]) | ||
# The full version, including alpha/beta/rc tags. | ||
release = fullversion | ||
release = latest_verion_from_github | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this |
||
|
||
# The language for content autogenerated by Sphinx. Refer to documentation | ||
# for a list of supported languages. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
**Added:** | ||
|
||
* <news item> | ||
|
||
**Changed:** | ||
|
||
* Method to retrieve the latest package version from GitHub's release page in the official documentation. The latest release on GitHub is used to retrieve the latest version of the package instead of a tag. | ||
|
||
**Deprecated:** | ||
|
||
* <news item> | ||
|
||
**Removed:** | ||
|
||
* <news item> | ||
|
||
**Fixed:** | ||
|
||
* <news item> | ||
|
||
**Security:** | ||
|
||
* <news item> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can dynamically get these information in our cookiecutting standard