Fix stdin pipe is being closed exception on Windows for large .proto files

[azam]

Summary

This fixes #2147.

ProcessRunner closes the stdin stream on execution which throws an IOException with Pipe is being closed message on Windows for protobuf files slightly larger than 4100 bytes. This fix removes the OutputStream#close() call on ProcessRunner, but this should not affect current behavior, since the file descriptor and stream for stdin will be closed when the process is destroyed (unix,windows).

Also added a test with a dirty .proto file that is slightly over 4100 bytes.

---

Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.

Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.

After creating the PR, please add a commit that adds a bullet-point under the [Unreleased] section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

• a summary of the change
• either
  • a link to the issue you are resolving (for small changes)
  • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the plugin-foo/CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

[nedtwigg]

I killed CI after 36 minutes, usually the tests complete in ~15 minutes.

Try running ./gradlew build locally. I'm seeing that BiomeStep and NativeCmdStep are hanging as a result of the original change. I just pushed up a PR which calls a flush instead of close, we'll see how it does.

[nedtwigg]

Stopped tests after 20 minutes this time.

[nedtwigg]

Seems that the close() is important. Maybe just calling flush() before the close() will solve your issue. Good thing you added a test, and good thing we run our tests on Windows! https://stackoverflow.com/a/56013102/24181017

[azam]

Nice find! My bad that I should have run the full test suite 😅
Thank you for your time working on this issue.