Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2 mirror for maven plugin #1821

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Conversation

jibidus
Copy link

@jibidus jibidus commented Sep 21, 2023

Support configuration of P2 mirrors in maven plugin (fixes #1697).

Here is how to declare new mirrors:

  <eclipse>
   …
    <p2Mirrors>
      <p2Mirror>
        <prefix>https://download.eclipse.org/</prefix>
        <url>https://some.internal.mirror/eclipse</url>
      </p2Mirror>
    </p2Mirrors>
  </eclipse>

Notes:

  • I tried to write a test with Wiremock, but didn't succeed 😢 (cannot find how to declare a trusted certificate, since connection is through SSL)
  • I cannot test manually by publishing a new version locally 😢 (./gradlew publishToMavenLocal fail with error Configuration cache problems found in this build)

@jibidus jibidus force-pushed the p2-mirror-for-maven-plugin branch 2 times, most recently from 9e05e79 to b12d6eb Compare September 28, 2023 07:20
@jibidus jibidus force-pushed the p2-mirror-for-maven-plugin branch from b12d6eb to d0fca7a Compare September 28, 2023 07:22
@nedtwigg nedtwigg enabled auto-merge September 28, 2023 16:23
@nedtwigg nedtwigg merged commit 6c1df6d into diffplug:main Sep 28, 2023
@jibidus jibidus deleted the p2-mirror-for-maven-plugin branch September 28, 2023 19:19
@nedtwigg
Copy link
Member

Shipped in plugin-gradle 6.22.0 and plugin-maven 2.40.0.

@jibidus
Copy link
Author

jibidus commented Sep 29, 2023

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to set P2 mirror for Maven plugin
2 participants